1912 Comp6284 Taca TK2-W5-S7-R0 Team3 4 PDF

Tugas Kelompok ke-2
Minggu ke-5 Sesi 7

Dari coding java untuk tes cetak report berikut:
a. Cari 4 tipe code smell and jelaskan!
b. Lakukan refactor untuk memperbaiki code smell tersebut!
1. import java.util.Random;
2. import java.util.Vector;
3.
4. public class MainSystem {
5.
6. public static void main(String[] args) {
7. String [] it = {"Sandal xl","Sandal l","Sandal v", "Shoes xl","Shoes l", "Shoes v"};
8. int [] pt = {100, 90, 80, 200, 190, 185};
9. int [] hp = {1200, 1150, 1100, 2500, 2300, 2200};
10. int [] m = {1, 1, 2, 3, 3, 4, 5};
11. Random r = new Random(232);
12. Report report = new Report();
13. Transaction t = new Transaction(1, 2016);
14.
15. for(int i=0; i<it.length; i++)
16. t.addItem(new Item(it[i], pt[i], hp[i], r.nextInt(500) + 1));
17. report.AddTransaction(t);
18. t = new Transaction(2, 2016);
COMP6284 – Code Reengineering

74.
75. report.printTransaction(1, 2016, 3, 2016);
78. }
79.
80. }
81.
82. class Item {
83. private String name;
84. private int price;
85. private int quantity;
86. private int highSeasonPrice;
87. private final int HIGH_SEASON_START = 5;
88. private final int HIGH_SEASON_END = 8;
89.
90. public Item(String name, int price, int highSeasonPrice, int quantity) {
91. this.name = name;
92. this.price = price;
93. this.highSeasonPrice = highSeasonPrice;
94. this.quantity = quantity;
95. }
96. public String getName() {
97. return name;
98. }
99.
100. public int getPrice(int currentMonth, int quantity) {
101. int price;
102. if(currentMonth >= HIGH_SEASON_START && currentMonth <= HIGH_SEASON_END)
103. price = highSeasonPrice * quantity;
104. else price = this.price * quantity;
105. return moreThanFiveThousand(price)?(price - 100): price;
106. }
107. public int getQuantity() {
108. return quantity;
109. }
110.
111. private boolean moreThanFiveThousand(int price) {
112. return price > 5000;
113. }
114. }
115.
116. class Transaction {
117. private Vector<Item> items = new Vector<>();
118. private int month;
119. private int year;

120. public Transaction(int month, int year) {
121. this.month= month;
122. this.year = year;
123. }
124. public Vector<Item> getItems() {
125. return items;
126. }
127. public int getMonth() {
128. return month;
129. }
130. public int getYear() {
131. return year;
132. }
133. public void addItem(Item item) {
134. items.add(item);
135. }
136. public int getTotalPrice(){
137. int total = 0;
138. for(Item e:items) {
139. total += e.getPrice(this.month, e.getQuantity());
140. }
141. return total;
142. }
143. }
144.
145. class Month {
146. private String[] months =
{"January","February","March","April","May","June","July","August","September","October","November","December"};
147. protected int month;
148. public String getText() {
149. return months[month - 1];
150. }
151. }
152.
153. class Report extends Month {
154. private Vector<Transaction> transactions = new Vector<>();
155. public void AddTransaction(Transaction tran){
156. transactions.add(tran);
157. }
158.
159. public int getTotalFor(int monthStart, int yearStart, int monthEnd, int yearEnd){
160. int sum = 0;
161. for(Transaction t: transactions)
162. if( (yearStart*100+monthStart) <= (t.getYear()*100+t.getMonth()) &&
(t.getYear()*100+t.getMonth()) <= (yearEnd*100+monthEnd) )
163. sum += t.getTotalPrice();
164. return sum;
165. }
166.
167. public void printTransaction(int monthStart, int yearStart, int monthEnd, int yearEnd) {
168.
169.
170. System.out.println("=================================================");
171. month = monthStart;
172. System.out.print("Report from " + getText() + " " + yearStart + " to ");
173. month = monthEnd;
174. System.out.println(getText() + " " + yearEnd);
176. int total = 0;
177. for(int year=yearStart; year<=yearEnd; year++) {
178. int me = year < yearEnd ? 12 : monthEnd;
179. int ms = year == yearStart ? monthStart : 1;
180. for(int m=ms; m<=me; m++) {
181. month = m;

182. System.out.format("Year %d Month %-10s : %,15d\n", year, getText(),
getTotalFor(m, year, m, year));
183. total += getTotalFor(m, year, m, year);
184. }
185. }
187. System.out.format("Total Transaction = %,15d\n", total);
189. }
190. }

Jawab
a. Cari 4 tipe code smell and jelaskan!

Tipe code smell yang terdapat pada code tersebut yaitu :
1. Kelompok The Bloater, dengan jenis code smell long method yang terdapat pada 2 class,
yaitu class Mainsystem dan class Report, the bloater merupakan kelompok code smell yang
menunjukkan sesuatu yang berkembang terlalu besar sehingga tidak dapat ditangani secara
efisien. Sesuatu tersebut dapat berupa metode yang terlalu panjang, kelas yang terlalu
besar, daftar parameter yang terlalu banyak, penggunaan data primitive yang berlebihan,
ataupun penggunaan data clumps. Pada code tersebut terdapat 2 class yang mengandung
Method yang isinya sangat banyak.
Potongan code pada Class Mainsystem yang mengandung code smell long method yaitu,
String [] it = {"Sandal xl","Sandal l","Sandal v", "Shoes xl","Shoes l",

"Shoes v"};
int [] pt = {100, 90, 80, 200, 190, 185};
int [] hp = {1200, 1150, 1100, 2500, 2300, 2200};
int [] m = {1, 1, 2, 3, 3, 4, 5};
Random r = new Random(232);
Report report = new Report();
Transaction t = new Transaction(1, 2016);
for(int i=0; i<it.length; i++)

t.addItem(new Item(it[i], pt[i], hp[i], r.nextInt(500) +
1));
report.AddTransaction(t);
t = new Transaction(2, 2016);
1));
1));
1));
1));

1));
1));
1));
1));
1));

1));
1));
1));
1));
1));
report.printTransaction(1, 2016, 3, 2016);


}
Potongan code pada Class Report yang mengandung code smell long method yaitu,
int total = 0;
System.out.format("Year %d Month %-10s : %,15d\n", year, getText(),

getTotalFor(m, year, m, year));
total += getTotalFor(m, year, m, year);
System.out.println("=================================================");
System.out.format("Total Transaction = %,15d\n", total);
System.out.println("=================================================");}
2. Kelompok The dispensable dengan jenis code smell Dead Code yang terdapat pada class
MainSystem di baris/line nomor 10. The dispensable adalah adanya sesuatu yang tidak
dibutuhkan dan seharusnya dapat dihapus dari source code. Pada code tersebut terdapat
1 class yang mengandung Dead code dimana kode program dapat dihapus karena tidak
dipakai saat eksekusi program.
Potongan code pada Class Mainsystem yang mengandung code smell Dead Code yaitu,
int [] m = {1, 1, 2, 3, 3, 4, 5};
3. Kelompok The Coupler dengan jenis code smell Feature Envy yang terdapat pada class
MainSystem . The coupler merupakan kondisi dimana terdapat pelanggaran terhadap
prinsip coupling. Coupling merupakan ukuran keterikatan sebuah module dengan module
lainnya. Prinsip coupling menekankan pada penerapan low coupling, sehingga perubahan
pada satu module tidak akan (atau sedikit) mempengaruhi module lainnya. Salah satu
kondisi pelanggaran prinsip coupling adalah dimana sebuah metode mengakses data dari
object lainnya lebih sering dibandingkan data dari dalam kelas itu sendiri. Penggunaan
middle man juga merupakan indikasi pelanggaran dari prinsip low coupling. Pada code
tersebut terdapat 1 class yang mengandung Feature Envy dimana kode program tersebut
mengandung Sebuah method yang sangat bergantung pada data yang ada di class lain,
bukan di data milik class tempat method tersebut berada.
Potongan code pada Class Mainsystem yang mengandung code smell Feature Envy
yaitu,

This<not referenced> , Report AddTransaction(…) printTransaction(…)Report(),
Transaction Transaction(…) additem(…), item item(…), Random nextInt(…) Random(…)
public static void main(String[] args) {
report();
private static Report report() {

String[] it = { "Sandal xl", "Sandal l", "Sandal v", "Shoes xl",
"Shoes l", "Shoes v" };
int[] pt = { 100, 90, 80, 200, 190, 185 };
int[] hp = { 1200, 1150, 1100, 2500, 2300, 2200 };
for (int i = 0; i < it.length; i++) {
t.addItem(new Item(it[i], pt[i], hp[i], r.nextInt(500) + 1));
}
}
}
}
}
}
}
}

}
}
}
}
}
}
}
return report;}
4. Kelompok The dispensable dengan jenis code smell Duplicate Code yang terdapat pada
class MainSystem . The dispensable adalah adanya sesuatu yang tidak dibutuhkan dan
seharusnya dapat dihapus dari source code. Pada code tersebut terdapat 1 class yang
mengandung Duplicate Code dimana kode tersebut memiliki kode program yang
terduplikasi.
Potongan code pada Class Mainsystem yang mengandung code smell Duplicate Code
yaitu,
report();

int[] pt = { 100, 90, 80, 200, 190, 185 };
int[] hp = { 1200, 1150, 1100, 2500, 2300, 2200 };
}
}
}
}
}
}
}
}
}

}
}
}
}
}
}
return report;}
b. Dari source code tersebut terdapat beberapa code smell, diantaranya yaitu code
smell long method, duplicate code, dead code, dan feature envy. Berikut hasil
refactoring dari tim kami,
import java.util.Random;
import java.util.Vector;
public class MainSystem {

report();

int[] pt = { 100, 90, 80, 200, 190, 185 };
int[] hp = { 1200, 1150, 1100, 2500, 2300, 2200 };

}
}
}
}
}
}
}
}
}
}
}

}
}
}
}
return report;
}
class Item {
private String name;
private int price;
private int quantity;
private int highSeasonPrice;
private final int HIGH_SEASON_START = 5;
private final int HIGH_SEASON_END = 8;
public Item(String name, int price, int highSeasonPrice, int quantity) {

this.name = name;
this.price = price;
this.highSeasonPrice = highSeasonPrice;
this.quantity = quantity;
}
public String getName() {
return name;
}
public int getPrice(int currentMonth, int quantity) {

int price;
if(currentMonth >= HIGH_SEASON_START && currentMonth <=
HIGH_SEASON_END)
price = highSeasonPrice * quantity;
else price = this.price * quantity;
return moreThanFiveThousand(price)?(price - 100): price;
}
public int getQuantity() {

return quantity;
}
private boolean moreThanFiveThousand(int price) {

return price > 5000;
}
}
class Transaction {
private Vector<Item> items = new Vector<>();
private int month;
private int year;
public Transaction(int month, int year) {
this.month= month;
this.year = year;
}
public Vector<Item> getItems() {
return items;
}
public int getMonth() {
return month;
}
public int getYear() {
return year;
}
public void addItem(Item item) {
items.add(item);
}
public int getTotalPrice(){
int total = 0;
for(Item e:items) {
total += e.getPrice(this.month, e.getQuantity());
}
return total;
}
}
class Month {
private String[] months =
{"January","February","March","April","May","June","July","August","Septembe
r","October","November","December"};
protected int month;
public String getText() {
return months[month - 1];
}
}
class Report extends Month {

private Vector<Transaction> transactions = new Vector<>();
public void AddTransaction(Transaction tran){
transactions.add(tran);
}
public int getTotalFor(int monthStart, int yearStart, int monthEnd, int

yearEnd){

int sum = 0;
for(Transaction t: transactions)
if( (yearStart*100+monthStart) <= (t.getYear()*100+t.getMonth())
&& (t.getYear()*100+t.getMonth()) <= (yearEnd*100+monthEnd) )
sum += t.getTotalPrice();
return sum;
}
public void printTransaction(int monthStart, int yearStart, int

monthEnd, int yearEnd) {
month = monthStart;
System.out.print("Report from " + getText() + " " + yearStart + " to
");
month = monthEnd;
System.out.println(getText() + " " + yearEnd);
int total = total(monthStart, yearStart, monthEnd, yearEnd);
System.out.format("Total Transaction = %,15d\n", total);
}
private int total(int monthStart, int yearStart, int monthEnd, int

yearEnd) {
int total = 0;
for (int year = yearStart; year <= yearEnd; year++) {
int me = year < yearEnd ? 12 : monthEnd;
int ms = year == yearStart ? monthStart : 1;
for (int m = ms; m <= me; m++) {
month = m;
System.out.format("Year %d Month %-10s : %,15d\n", year,
getText(), getTotalFor(m, year, m, year));
total += getTotalFor(m, year, m, year);
}
}
return total;
}
}

Sumber :
 https://thesolidsnake.wordpress.com/2013/05/03/belajar-mencium-bau-nya-kode-
program-code-smell/
 https://www.altexsoft.com/blog/engineering/code-refactoring-best-practices-
when-and-when-not-to-do-it/
 https://dzone.com/articles/smells-in-java-code-do-you-recognize-them
 https://dzone.com/articles/staring-into-my-java-crystal-ball-2020
 https://refactoring.guru/refactoring/smells
 Eclipse – workspace
 Intellij IDEA
 Lecture Note

1912 Comp6284 Taca TK2-W5-S7-R0 Team3 4 PDF

Загружено:

Сведения о документе

Исходное описание:

Оригинальное название

Авторское право

Доступные форматы

Поделиться этим документом

Поделиться или встроить документ

Параметры публикации

Этот документ был вам полезен?

Это неприемлемый материал?

Авторское право:

Доступные форматы

1912 Comp6284 Taca TK2-W5-S7-R0 Team3 4 PDF

Загружено:

Авторское право:

Доступные форматы

Tugas Kelompok ke-2

Minggu ke-5 Sesi 7

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

a. Cari 4 tipe code smell and jelaskan!

String [] it = {"Sandal xl","Sandal l","Sandal v", "Shoes xl","Shoes l",

for(int i=0; i<it.length; i++)

COMP6284 – Code Reengineering

for(int i=0; i<it.length; i++)

report.printTransaction(1, 2016, 3, 2016);

COMP6284 – Code Reengineering

System.out.format("Year %d Month %-10s : %,15d\n", year, getText(),

total += getTotalFor(m, year, m, year);

System.out.format("Total Transaction = %,15d\n", total);

int [] m = {1, 1, 2, 3, 3, 4, 5};

COMP6284 – Code Reengineering

private static Report report() {

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

public class MainSystem {

public static void main(String[] args) {

private static Report report() {

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

public Item(String name, int price, int highSeasonPrice, int quantity) {

public int getPrice(int currentMonth, int quantity) {

COMP6284 – Code Reengineering

private boolean moreThanFiveThousand(int price) {

class Report extends Month {

public int getTotalFor(int monthStart, int yearStart, int monthEnd, int

COMP6284 – Code Reengineering

public void printTransaction(int monthStart, int yearStart, int

private int total(int monthStart, int yearStart, int monthEnd, int

COMP6284 – Code Reengineering

COMP6284 – Code Reengineering

Вам также может понравиться