I have a simply supported beam with a pin on one end and a roller on the other.

The length of the beam is 25 feet. If there is a moment of 30 kips/ft at each support going clockwise, what does the shear and moment diagrams look like? I am going to assume you meant 30 kip-ft for those moments, 30 k/ft means a distributed load along the beam. I will detail for you the procedure for determining this. First off, you need to do some statics. Find the reactions at the suports (sum the moments about 1 support to get the reaction at the other, sum forces). For this particular problem, you should get 2.4 kips down on the left rxn, and 2.4 kips up on the right rxn. Now lets do the shear diagram. Start at the left, and follow the forces. At the support, there is a 2.4 kip downward (negative) force, so your diagram goes straight down from zero to -2.4. Now "walk" across the beam. Since you encounter no forces and no discontinuities, the diagram is a straight line (at -2.4) all the way across. When we reach the right side, we encounter a 2.4 kip force upward (the reaction), so the diagram goes up 2.4 kips, closing it out at zero. Now there are a couple methods for the moment diagram. The easiest is to use the area under the shear diagram. The area under the shear diagram between any 2 points is equal to the difference in moment between those 2 points. We'll use your problem as an example. Starting at the left support, you've got 30 kip-ft of moment. Is this positive or negative? Some teachers prefer positive to be counter clockwise, some use "compression side positive" notation (which I prefer). For the sake of what you're doing, I'll do both. So if CCW is positive, at the left support we have a positive moment of 30 k-ft applied, so your diagram goes straight up from zero to 30. There is nothing to cause moment anywhere in the middle of the beam, so lets go to the right support. What is the area under the shear diagram from one support to the other? It is a rectangle, -2.4 kip height X 25 ft long = -60 k-ft area. So from the left support to the right, the moment changes by -60. It started at +30, so 30-60 = -30 k-ft at the right support. So a straight line goes from +30 at the left support to -30 at the right support. Then we come across the applied +30 k-ft load, so that's a straight line upwards again, closing out the diagram at zero. Does this all make physical sense? At the supports, there is no moment reaction, so we start at zero, then instantly jump to the applied moment. So far so good. The sign is different at each because the moments bend the beam differently at each end (downward at the left, up at the right). There is no internal moment in the middle of the beam (where the diagram crosses the axis), because at that point the reactions and the applied moments balance out. Now lets look at compression side negative convention. This convention takes a moment to be positive any time it results in the beam having its compression side on the top. Imagine a beam with a point load in the middle. When the beam bends, the bottom stretches (tension) while the top compresses. The compression is on top, so we get positive moment. An easy way to tell is to ask yourself "does this load or moment make the beam smile?". If the beam smiles then the top is in compression. So from left to right: At the left support, 30 k-ft. Imagine it bending the beam, what does the beam do? Smile, so the 30 k-ft is positive. No applied loads or moments across the beam, so the diagram is a straight line. At the right support, what does this 30 k-ft do? Frown, so negative. Connect the dots, +30 to -30. Same diagram, a fraction of the work. There are other more detailed methods, which your teacher should have presented to you. For complicated loadings, you have to cut the beam into sections and do statics, using internal loads as reactions.